Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly import types in Typescript files #43554

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 13, 2024

Summary

Types need to be imported like import type { ... } from ... or import { type ..., type ...} from ....
This fixes some invalid imports and makes #43553 a bit smaller.

Checklist

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug 3. to review Waiting for reviews labels Feb 13, 2024
@susnux susnux added this to the Nextcloud 29 milestone Feb 13, 2024
@susnux susnux marked this pull request as ready for review February 13, 2024 17:08
@susnux susnux merged commit b63abda into master Feb 13, 2024
96 checks passed
@susnux susnux deleted the fix/types-import branch February 13, 2024 19:45
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants