Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only cleanup orphaned shared daily #43605

Merged
merged 1 commit into from
Feb 23, 2024
Merged

only cleanup orphaned shared daily #43605

merged 1 commit into from
Feb 23, 2024

Conversation

icewind1991
Copy link
Member

Since we filter out the shares with no matching files when loading them already there is no real downsides to leaving them in the db a bit longer.

Reducing the interval should decrease the db load a bit

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Feb 15, 2024
@icewind1991 icewind1991 added this to the Nextcloud 29 milestone Feb 15, 2024
@icewind1991 icewind1991 requested review from nickvergessen, a team, ArtificialOwl, nfebe and sorbaugh and removed request for a team February 15, 2024 15:53
Signed-off-by: Robin Appelman <robin@icewind.nl>
Copy link
Member

@joshtrichards joshtrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we filter out the shares with no matching files when loading them already

You had me at this. :-)
Makes sense.

@skjnldsv skjnldsv merged commit d541a7d into master Feb 23, 2024
159 checks passed
@skjnldsv skjnldsv deleted the orphan-share-daily branch February 23, 2024 18:43
@juliusknorr
Copy link
Member

/backport to stable28

@juliusknorr
Copy link
Member

/backport to stable27

@juliusknorr
Copy link
Member

/backport to stable26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants