Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Align icon of widgets with the images #43702

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 20, 2024

As mentioned by @jancborchardt the icon next to the widget title should be aligned with the center of the item list entry images:

🏚️ Before 🏡 After
Screenshot 2024-02-20 at 18 45 46 Screenshot 2024-02-20 at 18 45 24

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot looks good :)

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the fix/dashboard-icon-position branch from 460f0a0 to a01860e Compare February 21, 2024 07:30
@juliusknorr
Copy link
Member Author

/compile

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 21, 2024
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliusknorr juliusknorr merged commit 89b2859 into master Feb 21, 2024
97 checks passed
@juliusknorr juliusknorr deleted the fix/dashboard-icon-position branch February 21, 2024 09:50
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants