-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't put the SMTP password into the HTML code #4372
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @MorrisJobke and @schiessle to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #4372 +/- ##
=============================================
- Coverage 54.07% 37.63% -16.45%
- Complexity 21589 21591 +2
=============================================
Files 1327 1327
Lines 82303 82280 -23
Branches 1305 1305
=============================================
- Hits 44509 30966 -13543
- Misses 37794 51314 +13520
|
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
<select name='mail_smtpauthtype' id='mail_smtpauthtype'> | ||
<p id="setting_smtpauth" <?php if ($_['mail_smtpmode'] !== 'smtp') print_unescaped(' class="hidden"'); ?>> | ||
<label for="mail_smtpauthtype"><?php p($l->t('Authentication method')); ?></label> | ||
<select name="mail_smtpauthtype" id="mail_smtpauthtype'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One '
was not replaced 🙈 (see #11218)
Fix #4354