-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dav): update a principal's schedule-default-calendar-URL #43745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
st3iny
force-pushed
the
feat/dav/write-default-calendar-url
branch
from
February 27, 2024 22:32
d7a272d
to
69bd8be
Compare
st3iny
changed the title
feat(dav): implement updating a principal's schedule-default-calendar…
feat(dav): update a principal's schedule-default-calendar-URL
Feb 27, 2024
st3iny
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Feb 28, 2024
st3iny
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
February 28, 2024 08:26
(Code style fixes are resolved locally. I'll push later to prevent wasting CI time.) |
Merged
2 tasks
ChristophWurst
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean ✨
Comment on lines
+79
to
+87
Scenario: Update a principal's schedule-default-calendar-URL | ||
Given user "user0" exists | ||
And "user0" creates a calendar named "MyCalendar2" | ||
When "user0" updates property "{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL" to href "/remote.php/dav/calendars/user0/MyCalendar2/" of principal "users/user0" on the endpoint "/remote.php/dav/principals/" | ||
Then The CalDAV response should be multi status | ||
And The CalDAV response should contain a property "{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL" | ||
When "user0" requests principal "users/user0" on the endpoint "/remote.php/dav/principals/" | ||
Then The CalDAV response should be multi status | ||
And The CalDAV response should contain a property "{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL" with a href value "/remote.php/dav/calendars/user0/MyCalendar2/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
tcitworld
approved these changes
Feb 28, 2024
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
feat/dav/write-default-calendar-url
branch
from
February 28, 2024 13:51
69bd8be
to
53ef6c5
Compare
st3iny
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Feb 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
enhancement
feature: caldav
Related to CalDAV internals
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow updating a principal's
schedule-default-calendar-URL
via aPROPPATCH
. The property will be saved inoc_properties
.TODO
Checklist