Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make the app-level a component (AppLevelBadge) #43770

Merged
merged 2 commits into from
Mar 6, 2024
Merged

feat: Make the app-level a component (AppLevelBadge) #43770

merged 2 commits into from
Mar 6, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 22, 2024 •
edited
Loading

Summary

Code refactoring to reduce duplicated code and make the appstore part better maintainable.

image

Screen Shot 2024-03-06 at 12 19 09

Checklist

@susnux susnux added this to the Nextcloud 29 milestone Feb 22, 2024
@susnux susnux force-pushed the enh/split-appstore-app-level branch from fb3b63a to 1e47046 Compare March 6, 2024 11:05
@susnux susnux marked this pull request as ready for review March 6, 2024 11:05
@susnux
Copy link
Contributor Author

susnux commented Mar 6, 2024

I guess this was already ready-to-review 2 weeks ago 🙈

@susnux susnux force-pushed the enh/split-appstore-app-level branch 2 times, most recently from 22efdb5 to a776d24 Compare March 6, 2024 11:21
szaimen
szaimen approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine but didnt test

@susnux susnux force-pushed the enh/split-appstore-app-level branch from a776d24 to a53abe9 Compare March 6, 2024 13:59
@susnux
feat: Make the app-level a component (AppLevelBadge)
8e53a88 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
63f4c79 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the enh/split-appstore-app-level branch from a53abe9 to 63f4c79 Compare March 6, 2024 14:04
@susnux susnux enabled auto-merge March 6, 2024 16:44
@susnux susnux merged commit 476c400 into master Mar 6, 2024
98 checks passed
@susnux susnux deleted the enh/split-appstore-app-level branch March 6, 2024 16:50
@susnux susnux mentioned this pull request Mar 7, 2024
Merged
4 tasks
@blizzz blizzz mentioned this pull request Mar 7, 2024
Merged
@ShGKme ShGKme mentioned this pull request Mar 16, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Pytal approved these changes

@szaimen szaimen szaimen approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@artonge artonge Awaiting requested review from artonge

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: apps management
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @skjnldsv @Pytal @szaimen