Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fetch custom app store url without internet connection #43972

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Mar 4, 2024

We should still fetch custom app store urls even when having has_internet_connection configured to false as the app store might be in the internal network.

@juliusknorr juliusknorr requested review from come-nc, a team, icewind1991 and nfebe and removed request for a team March 4, 2024 08:46
@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Mar 4, 2024
@juliusknorr juliusknorr added this to the Nextcloud 29 milestone Mar 4, 2024
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the fix/fetch-custom-appstore branch from 45d18d0 to e13fb46 Compare March 4, 2024 11:47
@juliusknorr juliusknorr merged commit 646d5ad into master Mar 4, 2024
160 checks passed
@juliusknorr juliusknorr deleted the fix/fetch-custom-appstore branch March 4, 2024 14:00
@juliusknorr
Copy link
Member Author

/backport to stable28

@juliusknorr
Copy link
Member Author

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants