-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cron): Fix Cron misrepresenting itself as console #44094
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarity is important. 🙂 Thanks!
@helmo Could you rebase and reword your commit using conventional commits? |
3cea598
to
eb224c8
Compare
@Altahrim that should do it. |
@helmo Can you also sign your commit to pass DCO please? |
Signed-off-by: Herman van Rink <rink@initfour.nl>
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Summary
While working on #42449 I noticed that a log string was incorrect. And since that is now resolved via another PR I've spun this off into a separate branch.
console.php and cron.php logging the same name was a bit confusing at one time. So this is the fix.
Checklist