fix(files): Only add copy suffix before file extension for files (not folders) #44417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
szaimen,
emoral435 and
Pytal
and removed request for
a team
susnux
changed the title
|
/backport to stable28 |
Pytal
approved these changes
Mar 22, 2024
…re file extension Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/files-suffix-folders
branch
from
c061de9
to
387c2ff
Compare
|
/compile amend |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/files-suffix-folders
branch
from
387c2ff
to
929c3df
Compare
skjnldsv
reviewed
Mar 22, 2024
| * @return Either the initial name, if unique, or the name with the suffix so that the name is unique | ||
| */ | ||
| export const getUniqueName = (name: string, otherNames: string[], suffix = (n: number) => `(${n})`): string => { | ||
| export const getUniqueName = ( |
There was a problem hiding this comment.
todo: move to @nextcloud/vue 🙈
There was a problem hiding this comment.
yes, brain died while writing my message 🙈
skjnldsv
approved these changes
Mar 23, 2024
Merged
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(copy)misplaced with some filenames #43843Summary
For files keep the behavior (
file.name->file (copy).name) but for folders ignore the extension (folder.name->folder.name (copy)).vokoscreenNG-2024-03-22_18-33-07.mp4
Checklist