Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): do not suggest to install new widgets if appstore is disabled #44506

Merged
merged 1 commit into from
Mar 28, 2024
Merged

fix(dashboard): do not suggest to install new widgets if appstore is disabled #44506

merged 1 commit into from
Mar 28, 2024

Conversation

tcitworld
Copy link
Member

Curious licences changes, will compile amend later.

I'm guessing 29 is still accepting things like that?

Checklist

@tcitworld tcitworld added this to the Nextcloud 29 milestone Mar 27, 2024
@tcitworld tcitworld requested review from skjnldsv, Pytal, a team and szaimen and removed request for a team March 27, 2024 14:42
@tcitworld
Copy link
Member Author

/compile amend /

@nextcloud-command nextcloud-command force-pushed the dashboard-no-widgets-if-no-appstore branch from 4bf0d9a to f9fe6ec Compare March 27, 2024 15:33
@Pytal
Copy link
Member

Pytal commented Mar 27, 2024

I'm guessing 29 is still accepting things like that?

Only for critical bugfixes I'd say though this does not seem critical to me

@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@tcitworld tcitworld force-pushed the dashboard-no-widgets-if-no-appstore branch from f9fe6ec to 9ba0168 Compare March 28, 2024 15:38
@tcitworld @nextcloud-command
fix(dashboard): do not suggest to install new widgets if appstore is …
7947668 
…disabled

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the dashboard-no-widgets-if-no-appstore branch from 9ba0168 to 7947668 Compare March 28, 2024 15:49
@Pytal Pytal merged commit cc5e54d into master Mar 28, 2024
167 checks passed
@Pytal Pytal deleted the dashboard-no-widgets-if-no-appstore branch March 28, 2024 18:19
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@szaimen szaimen Awaiting requested review from szaimen szaimen was automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: dashboard feedback-requested
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
3 participants
@tcitworld @Pytal @skjnldsv