Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(trashbin): Show user who deleted a file #44694

Merged
merged 3 commits into from
Apr 30, 2024
Merged

feat(trashbin): Show user who deleted a file #44694

merged 3 commits into from
Apr 30, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Apr 6, 2024 •
edited
Loading

Summary

image

Checklist

@Pytal Pytal added this to the Nextcloud 30 milestone Apr 6, 2024
@Pytal Pytal self-assigned this Apr 6, 2024
@Pytal Pytal force-pushed the feat/trashbin-deleted-by branch 6 times, most recently from 3b46ab2 to 6e49424 Compare April 17, 2024 22:42
@Pytal Pytal force-pushed the feat/trashbin-deleted-by branch from 6e49424 to 583517e Compare April 23, 2024 23:20
Base automatically changed from feat/trashbin-deleted-by to master April 23, 2024 23:42
@Pytal Pytal force-pushed the feat/show-trash-deleted-by branch from 0b0f9ad to b9f926e Compare April 24, 2024 18:44
@Pytal Pytal marked this pull request as ready for review April 24, 2024 18:51
@Pytal Pytal requested a review from skjnldsv as a code owner April 24, 2024 18:51
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 24, 2024
@Pytal Pytal requested review from artonge, nfebe and emoral435 April 24, 2024 18:52
@Pytal
Copy link
Member Author

Pytal commented Apr 24, 2024

For reviewers: Relevant changes are in first commit bda5270, second commit just refactors the columns into a separate file

@Pytal Pytal enabled auto-merge April 24, 2024 18:53
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 30, 2024
Pytal added 3 commits April 30, 2024 14:44
@Pytal
feat(trashbin): Show user who deleted a file
ce7b2c0 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
refactor(trashbin): Move columns into separate file
017fbfa 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: compile assets
e4057a2 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the feat/show-trash-deleted-by branch from b9f926e to e4057a2 Compare April 30, 2024 21:48
@Pytal Pytal merged commit c24f460 into master Apr 30, 2024
104 checks passed
@Pytal Pytal deleted the feat/show-trash-deleted-by branch April 30, 2024 22:05
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge artonge approved these changes

@nfebe nfebe Awaiting requested review from nfebe

@emoral435 emoral435 Awaiting requested review from emoral435

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: trashbin
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

trash bin: show user who deleted that file/folder
3 participants
@Pytal @artonge @skjnldsv