Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(3rdparty): Adjust dependencies to also require min. PHP 8.1 #44720

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 8, 2024

Checklist

@nickvergessen
Copy link
Member

❌ Block merging with outdated 3rdparty/

It works :)

@susnux
Copy link
Contributor Author

susnux commented Apr 8, 2024

The failing tests are probably unrelated gd.so missing sounds like CI setup failure not code related.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the 3rdparty-php-8-1 branch from 75cc108 to e720c47 Compare April 8, 2024 12:29
@susnux
Copy link
Contributor Author

susnux commented Apr 8, 2024

Adjusted 3rdparty to merge commit ✅

@susnux susnux merged commit 141abf3 into master Apr 8, 2024
159 checks passed
@susnux susnux deleted the 3rdparty-php-8-1 branch April 8, 2024 14:11
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants