Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(systemtags): Use built-in input label to satisfy a11y check of NcSelect #44869

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 16, 2024

Summary

Removes one Vue error from console (other possible fix: set label-outside to true).

Checklist

@susnux susnux added bug 3. to review Waiting for reviews labels Apr 16, 2024
@susnux susnux requested review from artonge, Pytal and emoral435 April 16, 2024 22:38
@susnux susnux added this to the Nextcloud 30 milestone Apr 16, 2024
@susnux
Copy link
Contributor Author

susnux commented Apr 16, 2024

/backport to stable29

@susnux
Copy link
Contributor Author

susnux commented Apr 16, 2024

/backport to stable28

susnux added 2 commits April 17, 2024 00:40
…Select

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/systemtags-input-label branch from 786cf84 to 07525af Compare April 16, 2024 22:40
Copy link
Contributor

github-actions bot commented May 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants