feat: add request id as comment to all queries #44884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
nickvergessen,
juliusknorr,
a team,
ArtificialOwl,
nfebe and
yemkareems
and removed request for
a team
|
Silly me, expecting various SQL implementations to support the same comment format... |
icewind1991
added
2. developing
juliusknorr
approved these changes
Apr 17, 2024
|
After todays call with the db expert we could even consider this for selects (if the query cache is disabled), which would be recommended anyways these days for MySQL/MariaDB. |
icewind1991
force-pushed
the
query-req-id
branch
from
2db5a5d to
885e813
Compare
So there would be no downside for always having this on? |
|
I think we should not have the request id there by default but could consider it as a config option if an admin is sure that they have the query cache enabled, otherwise there might be quite an overhead invalidating it with every query. |
icewind1991
force-pushed
the
query-req-id
branch
from
885e813 to
39317c2
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
query-req-id
branch
from
39317c2 to
8c10c78
Compare
|
Put the request id behind the |
nickvergessen
approved these changes
Apr 17, 2024
icewind1991
added
3. to review
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable27 |
This was referenced Apr 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the request id in the sql can be useful for various database debugging