Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] fix(files): Also restore shares after ownership transfer for object storage #44920

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Apr 18, 2024

Backport of #44904

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from Altahrim, artonge and susnux April 18, 2024 14:00
@backportbot backportbot bot added this to the Nextcloud 27.1.9 milestone Apr 18, 2024
@susnux susnux marked this pull request as ready for review April 18, 2024 14:00
…torage

When a file is moved between different storages then the file id is not (always) preserved.
This means the file id has to be adjusted for all shares.
So in case the file id does not exist anymore we try to find the new file id based on the
target path of the transfer and the path suffix of the share.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the backport/44904/stable27 branch from 87c52a2 to a5e8727 Compare April 18, 2024 14:05
@Altahrim Altahrim mentioned this pull request Apr 18, 2024
4 tasks
string $destinationUid,
array $shares,
OutputInterface $output) {
private function restoreShares(

Check notice

Code scanning / Psalm

MissingReturnType Note

Method OCA\Files\Service\OwnershipTransferService::restoreShares does not have a return type, expecting void
@Altahrim Altahrim merged commit 129e9fd into stable27 Apr 18, 2024
37 of 38 checks passed
@Altahrim Altahrim deleted the backport/44904/stable27 branch April 18, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants