Better wordings in the new user modal #44931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jerome-Herbinet
added
design
Pytal
reviewed
Apr 19, 2024
susnux
reviewed
Apr 19, 2024
jancborchardt
requested changes
Apr 22, 2024
There was a problem hiding this comment.
Added 2 suggestions, simplifying the language.
Also, we shouldn’t ever use the "(s)" singular/plural writing like "group(s)". Either we write only the plural (as in my suggestion), or we programmatically check:
- If nothing or multiple are put in, use plural
- If only 1 is put in, use singular
Pytal
reviewed
Jun 13, 2024
|
Looks good! Can you squash the commits @Jerome-Herbinet? |
Co-authored-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com> Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com> Co-authored-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com> Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
Jerome-Herbinet-better-wordings-in-new-user-modal
branch
from
b27fdb6 to
1c168da
Compare
|
Squashed and rebased |
susnux
approved these changes
Jun 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made some wording improvements ; those are more clear, IMO.
Should do what you see below. Tests from reviewers required ; thanks by advance to them.
Before
After
Checklist