-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CalDAV): remove UNKNOWN from room / resource consideration #44938
Conversation
Signed-off-by: Anna Larch <anna@nextcloud.com>
/backport to stable29 |
/backport to stable28 |
/backport to stable27 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about nextcloud/calendar#5706 (comment) ?
We could, but nobody has complained about the email notifications (yet) so I'm hesitant to touch it. |
/backport to stable29 |
/backport to stable28 |
/backport to stable27 |
The backport to # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b backport/44938/stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a28f2647
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44938/stable27 Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/44938/stable27."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/44938/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a28f2647
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44938/stable28 Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/44938/stable28."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
The
UNKNOWN
CU type might be given to legitimateATTENDEE
s of an event.Filtering only for specific CU types will allow for actual attendees to still receive invitations. There is nothing in the RFC that specifies that
UNKNOWN
is a "thing".Checklist