Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add missing parameter to docblock tag psalm-taint-sink #44966

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Apr 22, 2024

Summary

Fix error caught by newer psalm versions: https://github.com/nextcloud/server/actions/runs/8783970520/job/24101242428?pr=44533 (pr #44533)

Error: lib/public/DB/QueryBuilder/IQueryBuilder.php:995:2: InvalidDocblock: @psalm-taint-sink expects 2 arguments (see https://psalm.dev/008)

Checklist

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added the 3. to review Waiting for reviews label Apr 22, 2024
@come-nc come-nc added this to the Nextcloud 30 milestone Apr 22, 2024
@come-nc come-nc self-assigned this Apr 22, 2024
@come-nc come-nc requested review from nickvergessen and susnux April 22, 2024 14:40
@come-nc come-nc merged commit 9a51d29 into master Apr 23, 2024
157 checks passed
@come-nc come-nc deleted the fix/add-missing-docblock-parameter-querybuilder branch April 23, 2024 09:14
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants