fix(userstatus): catch unique constrain violation on revert #45055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
added
3. to review
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
/backport to stable29 |
|
/backport to stable28 |
ChristophWurst
approved these changes
Apr 26, 2024
miaulalala
requested review from
a team,
ArtificialOwl,
yemkareems and
sorbaugh
and removed request for
a team
come-nc
approved these changes
May 6, 2024
Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
fix/revert-user-status-exception
branch
from
c39765d to
e43811d
Compare
This was referenced May 6, 2024
|
Backport to 27? #42625 (comment) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If during the revert of a status another operation wrote an additional status, the operation will fail with a unique constraint violation. Since we cannot determine which status is valid, we catch the exception and silently drop the revert.
Checklist