Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: TaskProcessing API #45094
feat: TaskProcessing API #45094
Changes from all commits
00894e2
8352b27
4b2acee
17486ad
ee7592f
44b896f
b2b93e4
86317bb
29cbb3c
3b0925a
1c033ae
7a94798
8e56626
5031a2e
843bb62
c9ea537
b150d77
4b954d2
eebeb82
bd5dfd0
3593d9b
9a2cd6b
928d04f
9effb55
996e507
6203c1c
ef44af1
8ccb29a
a5053d3
b85a0ed
5de42a5
2c87809
ef61c50
ec27c53
fff2fb8
4a3b9b8
20c09d1
beeee26
4d9a0ea
f2ab6cb
c079a61
a045e0c
0e06d64
f6f4965
eff862b
ec94a67
19a0aae
f3a88f0
a8afa7f
9cc1a01
715245a
e4b1d23
c020490
b11052f
ac36c78
a9a2cbf
c1f84aa
4ce5aaf
9864fc8
8d06338
f5a8bda
cac812d
6c4992d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since they are an array the names should be plural as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree. It's the shape of the input. It's one input (because it's input once) so one shape.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm that makes sense, how about just
input
andoutput
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it's not an input but just the shape of the input to be :)