Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(querybuilder): Remove temporary internal method executeUpdate() #45122

Merged
merged 1 commit into from
May 2, 2024
Merged

fix(querybuilder): Remove temporary internal method executeUpdate() #45122

merged 1 commit into from
May 2, 2024

Conversation

nickvergessen
Copy link
Member

Couldn't find any reference anymore in any off the apps I have checked out locally.
Since it's "before first beta" I guess we are okay now to clear it

Checklist

@nickvergessen
fix(querybuilder): Remove temporary internal method executeUpdate()
90ba7db 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 30 milestone Apr 30, 2024
@nickvergessen nickvergessen self-assigned this Apr 30, 2024
come-nc
come-nc approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 When do we remove execute ?

@nickvergessen
Copy link
Member Author

🧹 When do we remove execute ?

@deprecated 22.0.0 Use executeQuery or executeStatement => 31 it seems

@nickvergessen nickvergessen requested a review from bigcat88 May 2, 2024 08:46
bigcat88
bigcat88 approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not use this deprecated method either

@nickvergessen nickvergessen merged commit e5f5f06 into master May 2, 2024
154 of 157 checks passed
@nickvergessen nickvergessen deleted the techdebt/noid/remove-temporary-executeUpdate branch May 2, 2024 09:06
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@bigcat88 bigcat88 bigcat88 approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @bigcat88 @come-nc