Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Drop ical.js from dependencies #45125

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 30, 2024

Summary

This seems to be fully replaced with @nextcloud/calendar-availablity

Checklist

@susnux susnux added this to the Nextcloud 30 milestone Apr 30, 2024
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem to be used directly any more. It is still a peer of calendar-availability-vue etc. though.

@susnux
Copy link
Contributor Author

susnux commented Apr 30, 2024

It is still a peer of calendar-availability-vue etc. though.

Peers are automatically installed by NPM even if not specified.

@st3iny
Copy link
Member

st3iny commented Apr 30, 2024

It is still a peer of calendar-availability-vue etc. though.

Peers are automatically installed by NPM even if not specified.

Yeah right. No need to track it explicitly in package.json 👍

This seems to be fully replaced with `@nextcloud/calendar-availablity`

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/drop-ical-js branch from 50649c6 to 73de7a1 Compare April 30, 2024 16:53
@skjnldsv skjnldsv merged commit d1a31ca into master May 2, 2024
103 of 104 checks passed
@skjnldsv skjnldsv deleted the fix/drop-ical-js branch May 2, 2024 09:39
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants