Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove All files prefix from original location #45131

Merged
merged 2 commits into from
May 2, 2024
Merged

chore: Remove All files prefix from original location #45131

merged 2 commits into from
May 2, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Apr 30, 2024

Summary

  • Only show "All files" prefix for files deleted from root to see more of the path without hovering
Before After
image image

Checklist

Pytal added 2 commits April 30, 2024 16:49
@Pytal
chore: Remove All files prefix from original location
266c584 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: compile assets
15fbee2 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added 3. to review Waiting for reviews feature: trashbin labels Apr 30, 2024
@Pytal Pytal added this to the Nextcloud 30 milestone Apr 30, 2024
@Pytal Pytal self-assigned this Apr 30, 2024
@Pytal Pytal requested a review from skjnldsv as a code owner April 30, 2024 23:55
nimishavijay
nimishavijay approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

@Pytal Pytal enabled auto-merge May 1, 2024 15:51
@Pytal Pytal merged commit 1098abd into master May 2, 2024
104 checks passed
@Pytal Pytal deleted the chore/location-path-prefix branch May 2, 2024 09:32
jancborchardt
jancborchardt reviewed May 2, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thanks! :)

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt left review comments

@nimishavijay nimishavijay nimishavijay approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews feature: trashbin
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @jancborchardt @skjnldsv @nimishavijay