Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Changes the color of the "Delete User" and "X" exit buttons on hover. #45160

Merged
merged 1 commit into from
May 4, 2024
Merged

fix: Changes the color of the "Delete User" and "X" exit buttons on hover. #45160

merged 1 commit into from
May 4, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented May 2, 2024

⚠️ Needed to move this PR into the server repo for CI to work, original is: #43821

@theTyster @susnux
fix: Changes the color of the "Delete User" and "X" exit buttons on h…
c5b89ab 
…over.

Adjust 'X' close button border so that contrast is 3:1.

Co-authored-by: Ty Davis <noreply@mail.theTyster.dev>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ty <136642464+theTyster@users.noreply.github.com>
@susnux susnux added bug 4. to release Ready to be released and/or waiting for tests to finish labels May 2, 2024
@susnux susnux added this to the Nextcloud 30 milestone May 2, 2024
@susnux susnux requested review from skjnldsv and Pytal May 2, 2024 18:50
@susnux susnux requested review from a team, nfebe and sorbaugh and removed request for a team and sorbaugh May 3, 2024 20:18
@nfebe nfebe merged commit 3156602 into master May 4, 2024
104 checks passed
@nfebe nfebe deleted the fix/style branch May 4, 2024 20:03
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@nfebe nfebe nfebe approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feedback-requested
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @nfebe @Pytal @theTyster