Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not import styles that are already included in server bundle #45178

Merged
merged 2 commits into from
May 6, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented May 3, 2024

Summary

The styles are already included in server.css / server.scss.

Discovered while working on #43553

Checklist

@susnux susnux added bug 3. to review Waiting for reviews labels May 3, 2024
@susnux susnux added this to the Nextcloud 30 milestone May 3, 2024
@susnux susnux requested a review from a team May 3, 2024 20:17
@susnux susnux requested a review from skjnldsv as a code owner May 3, 2024 20:17
@susnux susnux requested review from nfebe, sorbaugh and Pytal and removed request for a team and sorbaugh May 3, 2024 20:17
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/style-imports branch from ab47d56 to 5d8133b Compare May 6, 2024 13:36
@susnux
Copy link
Contributor Author

susnux commented May 6, 2024

/compile

@susnux susnux enabled auto-merge May 6, 2024 13:36
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit a81f954 into master May 6, 2024
104 checks passed
@susnux susnux deleted the fix/style-imports branch May 6, 2024 15:53
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants