-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(setupChecks): update db version checks #45241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusting the minimum versions is very good! But I do not think we should add the upper version here.
Any particular reason? My thinking:
|
Makes sense because of the wording ("suggestion"). |
b7f1e55
to
ca31e35
Compare
4ddbe38
to
c3efa80
Compare
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
c3efa80
to
2915714
Compare
// we only care about X.Y not X.Y.Z differences | ||
[$major, $minor, ] = explode('.', $versionlc); | ||
$versionConcern = $major . '.' . $minor; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version_compare
is smart enough that you do not need to do this I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't when I tried it. It compares the full version string provided. Also I already had to be more specific for the PostgreSQL check anyway (since we only care about major and not even minor for that one).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://3v4l.org/T1lkh It works also if you do not care about minor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's mostly for the <= check because I wanted the code to literally state the min/max "versions" (release branches) supported just as they're written in the documentation.
Comparing against N+1 feels less self documenting. ;-)
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Summary
TODO
Follow-up ideas (i.e. out of scope) and other related notes:
Checklist