fix: Move hint about firewall issues to common helper string #45254
Conversation
susnux
requested review from
joshtrichards,
a team,
nfebe,
Pytal and
sorbaugh
and removed request for
a team
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Josh <josh.t.richards@gmail.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
|
I was just searching for the responsible code part, because it was in some bug reports on the forum (https://help.nextcloud.com/t/ipv6-only-cant-connect-to-itself/196260). Does it make sense to make a backport to current versions? Or is there a good reason not to do it? |
Summary
Currently the information why the setup check might have failed is duplicated, so move the information to the common helper string instead of only the mjs check.
Checklist