Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[uc] Introduce pagination in files-filter report #4530

Closed
wants to merge 4 commits into from
Closed

[uc] Introduce pagination in files-filter report #4530

wants to merge 4 commits into from

Conversation

icewind1991
Copy link
Member

Downstream 26507

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Apr 26, 2017
@icewind1991 icewind1991 added this to the Nextcloud 12.0 milestone Apr 26, 2017
@mention-bot
Copy link

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @SergioBertolinSG and @rullzer to be potential reviewers.

@rullzer
Copy link
Member

rullzer commented Apr 27, 2017

Tests are not happy

@rullzer rullzer added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 27, 2017
@MorrisJobke
Copy link
Member

@icewind Ping

@MorrisJobke MorrisJobke removed this from the Nextcloud 12.0 milestone May 16, 2017
@rullzer rullzer added this to the Nextcloud 13 milestone May 23, 2017
@MorrisJobke
Copy link
Member

@icewind1991 🏓

@codecov-io
Copy link

codecov-io commented Jul 4, 2017 •
edited by codecov bot
Loading

Codecov Report

Merging #4530 into master will increase coverage by 1.14%.
The diff coverage is 37.66%.

@@             Coverage Diff              @@
##             master    #4530      +/-   ##
============================================
+ Coverage     52.82%   53.97%   +1.14%     
+ Complexity    22817    22473     -344     
============================================
  Files          1443     1389      -54     
  Lines         88589    85984    -2605     
  Branches       1349     1329      -20     
============================================
- Hits          46795    46407     -388     
+ Misses        41794    39577    -2217
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/Files/Xml/FilterRequest.php 0% <0%> (ø) 13 <13> (?)
apps/dav/lib/Connector/Sabre/FilesReportPlugin.php 82.83% <80.55%> (-2.17%) 41 <5> (-3)
apps/files/appinfo/app.php 43.47% <0%> (-56.53%) 0% <0%> (ø)
core/Command/Maintenance/Mimetype/UpdateJS.php 0% <0%> (-52.64%) 13% <0%> (ø)
apps/files_sharing/appinfo/app.php 43.9% <0%> (-46.1%) 0% <0%> (ø)
apps/user_ldap/templates/part.settingcontrols.php 0% <0%> (-42.86%) 0% <0%> (ø)
apps/files_trashbin/appinfo/app.php 60% <0%> (-40%) 0% <0%> (ø)
apps/federation/lib/SyncJob.php 22.22% <0%> (-27.78%) 5% <0%> (+2%)
apps/user_ldap/templates/part.wizardcontrols.php 0% <0%> (-27.28%) 0% <0%> (ø)
lib/private/NavigationManager.php 56.45% <0%> (-22.94%) 38% <0%> (-5%)
... and 538 more

@icewind1991 icewind1991 force-pushed the downstream-26507 branch 2 times, most recently from 7db3bc2 to b19309d Compare July 4, 2017 16:45
@icewind1991
Copy link
Member Author

rebased, tests fixed

@MorrisJobke MorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 5, 2017
MorrisJobke
MorrisJobke requested changes Oct 27, 2017
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts :(

DeepDiver1975 and others added 3 commits October 31, 2017 12:52
@DeepDiver1975 @icewind1991
Introduce pagination in files-filter report
58cc324 
Signed-off-by: Thomas Müller <thomas.mueller@tmit.eu>
@icewind1991
Use a more API-style way to generate REPORT PROPFIND
f7c3e70 
This will also properly return 404 properties

Signed-off-by: Robin Appelman <robin@icewind.nl>

Signed-off-by: Vincent Petry <pvince81@owncloud.com>
@icewind1991
Adjust REPORT search query, perf and unit tests
20cd583 
- disable REPORT without filter

Because we need to use Node::search($pattern) to find all matching nodes
in all the subfolder recursively, but the result nodes contain
incomplete information like owner.

- remove unneeded trailing slash when buildling response href

This got obsoleted when switching to generateMultiStatus()

- add integration pagination test for favorites REPORT

- throw exception for unknown node types in FilesReportPlugin

Signed-off-by: Vincent Petry <pvince81@owncloud.com>
@icewind1991 icewind1991 force-pushed the downstream-26507 branch 2 times, most recently from 6eb72bf to df58047 Compare October 31, 2017 12:08
@icewind1991
adjust test
ab85432 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@MorrisJobke
Copy link
Member

@icewind1991 Failing unit tests

@MorrisJobke
Copy link
Member

@icewind1991 Should we try to get this in 13 or is 14 fine?

@MorrisJobke MorrisJobke mentioned this pull request Dec 8, 2017
Merged
28 tasks
@MorrisJobke
Copy link
Member

Let's move this to 14.

@MorrisJobke
Copy link
Member

@icewind1991 Ping

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 6, 2018
@MorrisJobke
Copy link
Member

Let's close this for now. If we want this later we can reopen it easily.

@MorrisJobke MorrisJobke deleted the downstream-26507 branch May 23, 2018 16:20
@MorrisJobke MorrisJobke removed this from the Nextcloud 14 milestone May 23, 2018
@CxsLucyfer CxsLucyfer mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke requested changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
2. developing Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@icewind1991 @mention-bot @rullzer @MorrisJobke @codecov-io @DeepDiver1975