Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Drop xml2js dependency and use browser native DOMParser #45387

Merged
merged 2 commits into from
May 17, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented May 17, 2024

Summary

We only care about browsers so we can use native DOMParser and do not need an additional dependency for XML parsing :)
So reduce our dependencies a bit 🧹

Checklist

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug 3. to review Waiting for reviews labels May 17, 2024
@susnux susnux added this to the Nextcloud 30 milestone May 17, 2024
@susnux susnux requested a review from a team May 17, 2024 08:05
@susnux susnux requested a review from skjnldsv as a code owner May 17, 2024 08:05
@susnux susnux requested review from Pytal, szaimen, sorbaugh and nfebe and removed request for a team and sorbaugh May 17, 2024 08:05
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux
Copy link
Contributor Author

susnux commented May 17, 2024

/compile

@susnux susnux enabled auto-merge May 17, 2024 09:41
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit 495d397 into master May 17, 2024
104 checks passed
@susnux susnux deleted the fix/xml2js branch May 17, 2024 11:21
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants