fix(Collaboration): Allow to enforce strict email format on sharees API #45425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndyScherzinger this would fix the email share issue |
susnux
force-pushed
the
fix/allow-strict-email
branch
from
1070d96 to
0c0e296
Compare
|
Should we add an UI toggle? |
Don't think that is needed. A config value is just fine. This is nothing that gets changed, you chose one or the other (forever) I suppose. |
Altahrim
reviewed
May 22, 2024
Only recommend a email address as sharee if it satisfies the strict format checking. Meaning before `a@b` was valid, while now with strict checking it is invalid and needs to be at least `a@b.c` Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/allow-strict-email
branch
from
136bfef to
a08575c
Compare
Altahrim
approved these changes
May 22, 2024
come-nc
approved these changes
May 23, 2024
@come-nc should I change this? I would be fine with that. Would be even more clean :) |
|
See: #45570 |
|
Closed in favor of #45570 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Only recommend a email address as sharee if it satisfies the strict format checking. Meaning before
a@bwas valid, while now with strict checking it is invalid and needs to be at leasta@b.cScreenshots
Checklist