fix(cron): Log excess memory usage at debug and info levels #45530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable29 |
joshtrichards
requested review from
come-nc,
nickvergessen,
ChristophWurst and
solracsf
szaimen
approved these changes
May 27, 2024
8 tasks
8 tasks
This comment was marked as off-topic.
This comment was marked as off-topic.
nickvergessen
force-pushed
the
jtr/fix-cron-memory-usage-levels
branch
from
0502646 to
6cae530
Compare
nickvergessen
approved these changes
Jun 11, 2024
Signed-off-by: Josh <josh.t.richards@gmail.com>
nickvergessen
force-pushed
the
jtr/fix-cron-memory-usage-levels
branch
from
6cae530 to
8ee070c
Compare
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
4. to release
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Admins/operators don't need to see this in day-to-day scenarios >= the default log level. Moved the 10MiB (common) to DEBUG level and the 300 MiB to INFO level (rarer but still common enough).
TODO
Checklist