-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(federatedfilesharing): import external federated share script #45606
Conversation
/backport to stable29 |
/backport to stable28 |
0cb0272
to
b8be96a
Compare
b8be96a
to
1c097fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/compile rebase / |
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
1c097fa
to
cd1394f
Compare
processSharesToConfirm() | ||
} | ||
|
||
$('body').on('window.OCA.Notification.Action', function(e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be also updated to non-jquery code by now:
https://github.com/nextcloud/notifications/blob/master/src/Components/Action.vue#L131
Is needed anyway as we phase out jQuery and an issue got raised in notifications to either ship it's own or migrate away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be much refactored, but for now just restored the previously working module as it was in past
/backport to stable29 |
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/45606/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7f0ffac7 cd1394f5
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45606/stable29 Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/45606/stable29."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Fix #44824
Notes
There are much more room to really improve and make it clean, but this is a fix with backport, and I will create a ticket once it's merged for technical debt