Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db): remove workaround for pqsql 9.4 and older #45629

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jun 2, 2024

  • Resolves: noid

Summary

The workaround was required because "ON CONFLICT DO NOTHING" was added with pqsql 9.5.

PostgreSQL 9.4 is eol since 2020-02-13 and thus everyone should use a version with upsert support nowadays.

TODO

  • CI
  • Review

Checklist

@kesselb kesselb self-assigned this Jun 2, 2024
@kesselb kesselb added 3. to review Waiting for reviews technical debt labels Jun 2, 2024
@kesselb kesselb added this to the Nextcloud 30 milestone Jun 2, 2024
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

Copy link
Member

@solracsf solracsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protected $compatModePre9_5 = null;
should be removed too.

@blizzz
Copy link
Member

blizzz commented Jun 3, 2024

Should be added to release notes https://github.com/nextcloud/documentation/blob/master/admin_manual/release_notes/upgrade_to_30.rst

The workaround was required because "ON CONFLICT DO NOTHING" was added with pqsql 9.5.

PostgreSQL 9.4 is eol since 2020-02-13 and thus everyone should use a version with upsert support nowadays.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the enh/noid/remove-workaround-pqsql-94 branch from 474797f to cac6443 Compare June 3, 2024 10:47
@kesselb
Copy link
Contributor Author

kesselb commented Jun 3, 2024

Should be added to release notes https://github.com/nextcloud/documentation/blob/master/admin_manual/release_notes/upgrade_to_30.rst

PR: nextcloud/documentation#11881

@kesselb kesselb requested a review from solracsf June 3, 2024 10:59
@solracsf solracsf added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 3, 2024
@kesselb kesselb merged commit b4467bf into master Jun 3, 2024
155 checks passed
@kesselb kesselb deleted the enh/noid/remove-workaround-pqsql-94 branch June 3, 2024 20:51
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants