-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show non writable folders during move or copy #45688
Conversation
/backport to stable29 |
/backport to stable28 |
2503fc7
to
580352a
Compare
580352a
to
89fe537
Compare
@artonge we need the library change, but you can already change it in this PR: (better also rename |
Don't we want to check the current folder's permissions instead of the selected nodes' permissions? |
89fe537
to
8452ba7
Compare
We want to ensure the picked folder has permissions, so checking the selected node is the way to go :) |
8452ba7
to
a058643
Compare
|
a058643
to
7475857
Compare
Rebased with the required library changes. |
7475857
to
62724ca
Compare
87d3b8e
to
b9b5ab4
Compare
b9b5ab4
to
36aa75f
Compare
Two pending issues:
|
36aa75f
to
38919a0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
38919a0
to
4e733e4
Compare
rebased and commit results of |
4e733e4
to
7ab40a9
Compare
/compile / |
Signed-off-by: Louis Chemineau <louis@chmn.me>
004e9c0
to
ae0106e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/45688/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ae0106ef
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45688/stable29 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
With ACL, a groupfolders might be non-writable but still contain writable sub folders.
Fix #44649
Fix nextcloud/groupfolders#2771
Fix nextcloud/groupfolders#2926