Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(files): Implement files list filters #45708

Merged
merged 6 commits into from
Jul 25, 2024
Merged

feat(files): Implement files list filters #45708

merged 6 commits into from
Jul 25, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 7, 2024 •
edited
Loading

Summary

Current state:

Bildschirmaufnahme_20240724_201030.webm
Old state:
Screencast_20240607_141239.webm

TODO

Not related but there are some visual issues, those will be fixed with next nextcloud-vue update (size of the user select etc).

  • Implement "people" filter
  • Design
  • Tests (follow up)

Checklist

@susnux susnux added this to the Nextcloud 30 milestone Jun 7, 2024
@susnux susnux self-assigned this Jun 7, 2024
@sorbaugh sorbaugh mentioned this pull request Jul 3, 2024
Closed
@susnux susnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 24, 2024
@susnux susnux marked this pull request as ready for review July 24, 2024 18:28
@susnux susnux requested a review from skjnldsv as a code owner July 24, 2024 18:28
AndyScherzinger
AndyScherzinger approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@AndyScherzinger AndyScherzinger mentioned this pull request Jul 24, 2024
Merged
skjnldsv
skjnldsv reviewed Jul 25, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@susnux susnux force-pushed the feat/files-filters branch 2 times, most recently from 608f2c4 to 1160fc4 Compare July 25, 2024 10:48
@susnux susnux requested a review from skjnldsv July 25, 2024 10:49
skjnldsv
skjnldsv approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very nice work!!! 🤩

@susnux
feat(files): Allow to add file list filters
968d412 
This adds sticky file list filters above the file list.
Those filters are used to filter the directory content and thus filter the file list.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux and others added 5 commits July 25, 2024 19:33
@susnux @skjnldsv
feat(files): Implement files list filters for name, modified time and…
842c21f 
… type

Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor: Make route parameters accessible using composables to reuse
aad0976 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
feat(files_sharing): Add file list filter to filter by owner / sharee
1fc6b79 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
test: Add cypress tests for file list filtering
2c0e2cc 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
66f77b5 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit 97ea957 into master Jul 25, 2024
109 checks passed
@susnux susnux deleted the feat/files-filters branch July 25, 2024 18:12
@juliushaertl juliushaertl mentioned this pull request Aug 3, 2024
Closed
@skjnldsv skjnldsv mentioned this pull request Aug 7, 2024
Open
This was referenced Aug 7, 2024
Closed
Closed
@Pytal Pytal mentioned this pull request Aug 13, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@Pytal Pytal Awaiting requested review from Pytal

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

Assignees

@susnux susnux

Labels
3. to review Waiting for reviews enhancement feature: files
Projects
📁 Files team
Status: ☑️ Done
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

Filetype filters on top of the files list (doc, pdf, jpg, ...)
4 participants
@susnux @AndyScherzinger @skjnldsv @sorbaugh