Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix(settings): Use axios directly for health check to preven URL sanitizing #45770

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jun 10, 2024

Backport of #45765

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from grnd-alt, Pytal and susnux June 10, 2024 19:51
@backportbot backportbot bot added the 3. to review Waiting for reviews label Jun 10, 2024
@backportbot backportbot bot added this to the Nextcloud 28.0.7 milestone Jun 10, 2024
@susnux
Copy link
Contributor

susnux commented Jun 11, 2024

/compile amend/

@susnux susnux marked this pull request as ready for review June 11, 2024 19:41
@susnux susnux added the bug label Jun 11, 2024
This was referenced Jun 12, 2024
@blizzz blizzz mentioned this pull request Jun 25, 2024
…tizing

When using Apache with `DirectorySlash` it will respond with 301 and the URL with trailing slash.
But when using traefik as the reverse proxy it can not rewrite redirects, this leads to the problem
that the Apache response is using HTTP in the redirect but the real server (traefik) is only listening on HTTPS.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@kesselb kesselb merged commit f9ec46d into stable28 Jul 3, 2024
45 checks passed
@kesselb kesselb deleted the backport/45765/stable28 branch July 3, 2024 16:30
@Altahrim Altahrim mentioned this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants