Fix/comment deleting with activities installed

[GVodyanov]

Summary

Fixes issue where you:

• Delete a comment
• Add a new comment before the old comment gets deleted in the back-end
• See deleted comment again

TODO

• Add store for synchronizing deleted comments between the mixin and activities

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Backports requested where applicable (ex: critical bugfixes)

[ShGKme]

I don't think it makes sense to introduce a global storage in the app just to store ids or deleted comments in 2-3 components.

If storing deleted state in the comment it self is a problem, it's enough to store it in the parent.

Besides, it seems that the initial issue is that adding a comment triggers an entire tab reload through loading state. What's when Comment instances are being destroyed and re-mounted without old deleted state.

[GVodyanov]

@ShGKme Would you have any suggestions on how to not make the tab reload then? I'm having trouble figuring out the activities API, thank you :)

[ShGKme]

So, I made a deeper look at the app.

With activity app case it is indeed not possible to store data in the parent, because on the Activity tab there is no parent between comments and the form. Every comment is a new Vue app. So, as a simple workaround from the server side, it is a good workaround.

A better solution would be to adjust Activity API to not reload everything on change. But with the current approach, it is not so simple.

So, let's fix Ferdinand's suggestion and go with it for now

cc @GretaD

[susnux]

A better solution would be to adjust Activity API to not reload everything on change. But with the current approach, it is not so simple.

💯 agree

[GretaD]

/backport to stable28

[GretaD]

/backport to stable29

[GretaD]

/compile amend /

[GretaD]

/compile amend /

[ChristophWurst]

The branch is outdated. Other PRs touched the frontend bundles. It will need a rebase and a recompile.

[GretaD]

/compile amend /

[susnux]

@GVodyanov

/home/runner/actions-runner/_work/server/server/apps/comments/src/store/deletedCommentLimbo.js
Error: 6:1 error Expected space or tab after '//' in comment spaced-comment

[GretaD]

/compile amend /

[ChristophWurst]

conflicts -> needs rebase + rebuild

[ChristophWurst]

/compile amend /

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

[backportbot]

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/45848/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick bd7c29c3

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45848/stable29

Error: No changes found in backport branch

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[backportbot]

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/45848/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick bd7c29c3

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45848/stable28

Error: No changes found in backport branch

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[susnux]

The backport to stable28 failed. Please do this backport manually.

When doing the backports @GVodyanov please directly include #46643