-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(comments): Use proper icon components instead of icon classes to fix dark mode #45867
Conversation
…fix dark mode Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
/backport to stable29 |
/backport to stable28 |
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Awesome!! |
@skjnldsv @susnux should this be re-backported to stable28 ? |
/backport to stable28 |
/backport to stable28 |
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/45867/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 93650e08 f8095023
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45867/stable28 Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/45867/stable28."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
When using the comments app with dark mode the icons are hard to see because they are all black.
This is fixed with using proper icon components.
Screenshots
Checklist