fix: move repair mimetype repair step to the expensive steps

[icewind1991]

Looking through the entire filecache takes a while

[icewind1991]

/backport to stable29

[icewind1991]

/backport to stable28

[kesselb]

Not ideal.

Adding mime types to existing files can be important to make certain functionality work.

Could you add a hint to lib/private/Repair/RepairMimeTypes.php that any update to the file must be mentioned in our release notes so that admin's know they have to run occ maintenance:repair --include-expensive?

[icewind1991]

• Added a separate "version" to track the ran mimetype migrations
• Added a setup check for when mimetype repair needs to be ran

[kesselb]

• Added a separate "version" to track the ran mimetype migrations
• Added a setup check for when mimetype repair needs to be ran

Thank you 👍

[juliusknorr]

Ideally we would split the operations that are performed for the new mimetype:

The insert into oc_mimetypes could be still in regular migration steps as it is just one insert for a new mimetype, that way it will already work for new files: https://github.com/nextcloud/server/blob/repair-mimetype-expensive/lib/private/Repair/RepairMimeTypes.php#L42-L44

Otherwise 👍

[icewind1991]

The insert into oc_mimetypes could be still in regular migration steps as it is just one insert for a new mimetype, that way it will already work for new files

There is no need to preemptively insert the rows into oc_mimetypes, it will be done on-demand if any file with the new mimetype is uploaded before the migration is ran.

The only thing required for new files to work is the mimetype mapping being updated, and that is part of the source upgrade.

[icewind1991]

redoing the other backports based on the 29 one

[Dexus]

/backport to stable27
/backport to stable26