chore: Move comments event handler to use proper event dispatcher #45951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 18, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
juliusknorr
force-pushed
the
chore/comments-event-legacy
branch
from
6a16461 to
15a0c0a
Compare
| } | ||
|
|
||
| $eventType = $event->getEvent(); | ||
| if ($eventType === CommentsEvent::EVENT_ADD |
Check notice
Code scanning / Psalm
DeprecatedConstant Note
| } | ||
|
|
||
| $applicableEvents = [ | ||
| CommentsEvent::EVENT_PRE_UPDATE, |
Check notice
Code scanning / Psalm
DeprecatedConstant Note
|
|
||
| $applicableEvents = [ | ||
| CommentsEvent::EVENT_PRE_UPDATE, | ||
| CommentsEvent::EVENT_UPDATE, |
Check notice
Code scanning / Psalm
DeprecatedConstant Note
| $applicableEvents = [ | ||
| CommentsEvent::EVENT_PRE_UPDATE, | ||
| CommentsEvent::EVENT_UPDATE, | ||
| CommentsEvent::EVENT_DELETE, |
Check notice
Code scanning / Psalm
DeprecatedConstant Note
juliusknorr
force-pushed
the
chore/comments-event-legacy
branch
from
15a0c0a to
2a3977e
Compare
juliusknorr
force-pushed
the
chore/comments-event-legacy
branch
4 times, most recently
from
f7563df to
9da9819
Compare
juliusknorr
force-pushed
the
chore/comments-event-legacy
branch
from
9da9819 to
536468e
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
chore/comments-event-legacy
branch
from
536468e to
9713dd3
Compare
blizzz
approved these changes
Jun 26, 2024
nickvergessen
approved these changes
Jun 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registering comments event handlers through the manager requires the comment manager to be initialized during app boot, which is something we can avoid by using the existing event dispatcher to make the registration more lazy.
Checklist