Add missing ContextWrite default task type in task processing manager #46003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigcat88
approved these changes
Jun 20, 2024
|
There seems to be one more here: https://github.com/nextcloud/server/blob/master/lib/public/TaskProcessing/TaskTypes/GenerateEmoji.php |
marcelklehr
reviewed
Jun 20, 2024
| @@ -395,6 +395,7 @@ private function _getTaskTypes(): array { | |||
| \OCP\TaskProcessing\TaskTypes\TextToTextSummary::ID => \OCP\Server::get(\OCP\TaskProcessing\TaskTypes\TextToTextSummary::class), | |||
| \OCP\TaskProcessing\TaskTypes\TextToImage::ID => \OCP\Server::get(\OCP\TaskProcessing\TaskTypes\TextToImage::class), | |||
| \OCP\TaskProcessing\TaskTypes\AudioToText::ID => \OCP\Server::get(\OCP\TaskProcessing\TaskTypes\AudioToText::class), | |||
| \OCP\TaskProcessing\TaskTypes\ContextWrite::ID => \OCP\Server::get(\OCP\TaskProcessing\TaskTypes\ContextWrite::class), | |||
There was a problem hiding this comment.
AH, damn. Yeah, please add the emoji one as well.
marcelklehr
approved these changes
Jun 20, 2024
…r::_getTaskTypes Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…er::_getTaskTypes Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
fix/noid/undeclared-context-write-task-type
branch
from
aa974f2 to
7e904ae
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted that while implementing a provider 😁