Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(userstatus): Fix user status automation in real-life scenario #46077

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jun 24, 2024

Steps

  1. Set a user status (message, emoji or both)
  2. Create a meeting in the calendar
  3. Run cron jobs
  4. Check content of oc_user_status (See backup status of 1 and live status of 2)
  5. Set availability so it does not currently apply
  6. Run cron jobs
    1. Expected: Check content of oc_user_status (See backup status of 1 and live status DND of 5)
    2. Actual: Check content of oc_user_status (See backup status of 1 and live status of 2)

If you replace step 2 with doing a call, it worked already.
Also tested with OOO and that one also failed to overwrite the meeting status.

Checklist

@nickvergessen nickvergessen added bug 3. to review Waiting for reviews feature: dav papercut Annoying recurring issue with possibly simple fix. feature: status labels Jun 24, 2024
@nickvergessen nickvergessen added this to the Nextcloud 30 milestone Jun 24, 2024
@nickvergessen nickvergessen self-assigned this Jun 24, 2024
@nickvergessen
Copy link
Member Author

/backport to stable29

@nickvergessen nickvergessen force-pushed the bugfix/noid/user-status-automation branch from 6540e12 to 3402d98 Compare June 24, 2024 15:13
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit. Tested with meeting / OOO and call / OOO

@nickvergessen nickvergessen force-pushed the bugfix/noid/user-status-automation branch from 3402d98 to ec5466d Compare June 25, 2024 07:27
Order of applying:
- Out-of-office
- Availability
- Call
- Meeting
- User status

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/user-status-automation branch from ec5466d to 2c977d2 Compare June 25, 2024 07:29
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels a bit like the rules for https://www.ultra-watten.com/watten-regeln ahahaha

Nice one, thanks for fixing that

@miaulalala miaulalala merged commit eed6216 into master Jun 25, 2024
165 checks passed
@miaulalala miaulalala deleted the bugfix/noid/user-status-automation branch June 25, 2024 09:32
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug feature: dav feature: status papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants