chore: Enable ESLint for apps and fix all errors #46082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
susnux
requested review from
ChristophWurst,
miaulalala,
nickvergessen,
st3iny and
skjnldsv
as code owners
st3iny
approved these changes
Jun 25, 2024
st3iny
reviewed
Jun 25, 2024
|
Nice find 🙈 |
ShGKme
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Thanks!
Checked all the changes, looks good.
I expected much more changes 👀
The only thing I'm working about is removing the import. Having a file it is not easily possible to say if removing this line is safe. And strictly, each file with dialogs must have dialog styles.
import '@nextcloud/password-confirmation/dist/style.css'
Comment on lines
+16
to
+17
| "lint": "eslint $(for appdir in $(ls apps); do if ! $(git check-ignore -q $appdir); then printf \"apps/$appdir \"; fi; done) core --no-error-on-unmatched-pattern", | ||
| "lint:fix": "eslint $(for appdir in $(ls apps); do if ! $(git check-ignore -q $appdir); then printf \"apps/$appdir \"; fi; done) core --no-error-on-unmatched-pattern --fix", |
There was a problem hiding this comment.
It's been worrying me for a year 🙈
ChristophWurst
approved these changes
Jun 25, 2024
susnux
force-pushed
the
chore/enable-eslint
branch
4 times, most recently
from
b7cdf76 to
df92bea
Compare
|
/compile |
susnux
force-pushed
the
chore/enable-eslint
branch
from
b816e37 to
91f4df6
Compare
|
Current blocker: |
susnux
force-pushed
the
chore/enable-eslint
branch
from
91f4df6 to
e626183
Compare
susnux
added
4. to release
susnux
force-pushed
the
chore/enable-eslint
branch
from
e626183 to
29c6ab3
Compare
|
Can we do that just after branch off 31 please 🙏 |
susnux
force-pushed
the
chore/enable-eslint
branch
from
29c6ab3 to
ccb97bd
Compare
Nevertheless this causes a huge amount of new warnings. Previously the shell script for directories to lint was wrong it was generating all app names to lint, but was missing the `apps/` prefix. Causing only `core` to be linted. Co-authored-by: Grigorii K. Shartsev <me@shgk.me> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
chore/enable-eslint
branch
from
ccb97bd to
b0f6686
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Nevertheless this causes a huge amount of new warnings. Previously the shell script for directories to lint was wrong it was generating all app names to lint, but was missing the
apps/prefix. Causing onlycoreto be linted.Checklist