Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix(Token): add FILESYSTEM scope with SCOPE_SKIP_PASSWORD_VALIDATION #46088

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jun 25, 2024

Backport of PR #46075

The scope design requires scopes to be either not specified, or
specified explicitely. Therefore, when setting the
skip-password-validation scope for user authentication from mechanisms
like SAML, we also have to set the filesystem scope, otherwise they will
lack access to the filesystem.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@backportbot backportbot bot requested review from artonge, juliusknorr and blizzz June 25, 2024 07:39
@backportbot backportbot bot added bug 3. to review Waiting for reviews labels Jun 25, 2024
@backportbot backportbot bot added this to the Nextcloud 28.0.7 milestone Jun 25, 2024
@blizzz blizzz changed the title [stable28] [stable29] fix(Token): add FILESYSTEM scope with SCOPE_SKIP_PASSWORD_VALIDATION [stable28] fix(Token): add FILESYSTEM scope with SCOPE_SKIP_PASSWORD_VALIDATION Jun 25, 2024
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 25, 2024
@blizzz blizzz merged commit 0d94a04 into stable28 Jun 25, 2024
51 of 54 checks passed
@blizzz blizzz deleted the backport/46075/stable28 branch June 25, 2024 10:09
@blizzz blizzz mentioned this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants