-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DAV): offset not applied #46219
Merged
blizzz
merged 1 commit into
master
from
fix/noid/infinit-BuildSocialSearchIndexBackgroundJob
Jul 1, 2024
Merged
fix(DAV): offset not applied #46219
blizzz
merged 1 commit into
master
from
fix/noid/infinit-BuildSocialSearchIndexBackgroundJob
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with more than 100 results, this job may never finish Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
/backport to stable29 |
conflicts, did manually |
blizzz
changed the title
fix(BuildSocialSearchIndexBackgroundJob): offset not applied
fix(DAV): offset not applied
Jul 1, 2024
@@ -59,6 +60,7 @@ | |||
->from('cards', 'c') | |||
->orderBy('id', 'ASC') | |||
->where($query->expr()->like('carddata', $query->createNamedParameter('%SOCIALPROFILE%'))) | |||
->andWhere($query->expr()->gt('id', $query->createNamedParameter((int)$offset, IQueryBuilder::PARAM_INT))) |
Check notice
Code scanning / Psalm
RedundantCastGivenDocblockType Note
Redundant cast to int given docblock-provided type
come-nc
approved these changes
Jul 1, 2024
ChristophWurst
approved these changes
Jul 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
with more than 100 results, this job may never finish
Question though: do we still need this job?
Checklist