Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] fix(setupchecks): skip check when disk_free_space is disabled #46223

Merged
merged 1 commit into from
Jul 2, 2024
Merged

[stable28] fix(setupchecks): skip check when disk_free_space is disabled #46223

merged 1 commit into from
Jul 2, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jul 1, 2024

Backport of PR #46190

@backportbot backportbot bot added this to the Nextcloud 28.0.8 milestone Jul 1, 2024
@joshtrichards joshtrichards added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 1, 2024
@joshtrichards
Copy link
Member

The drone failure makes zero sense. Figured we missed a related backport to stable28 or something. But code looks fine. WTH?

There was 1 failure:

1) Test\Group\DatabaseTest::testSearchGroups
Failed asserting that 3 is identical to 2.

/drone/src/tests/lib/Group/Backend.php:133

@kesselb
fix(setupchecks): skip check when disk_free_space is disabled
0353424 
Make it easier to discover that the check failed because disk_free_space is disabled.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@nickvergessen nickvergessen merged commit 57d41e4 into stable28 Jul 2, 2024
53 of 54 checks passed
@nickvergessen nickvergessen deleted the backport/46190/stable28 branch July 2, 2024 13:24
@Altahrim Altahrim mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@solracsf solracsf solracsf approved these changes

@joshtrichards joshtrichards Awaiting requested review from joshtrichards

Assignees

@kesselb kesselb

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: settings
Projects
None yet
Milestone
Nextcloud 28.0.8
Development

Successfully merging this pull request may close these issues.
4 participants
@joshtrichards @kesselb @solracsf @nickvergessen