Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3): Don't wait indefinitely for S3 to return #46317

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Jul 5, 2024

Summary

By default, SDK never timeout. Insert some sane defaults.
https://docs.aws.amazon.com/sdk-for-php/v3/developer-guide/guide_configuration.html#config-http

Checklist

@solracsf solracsf added the 3. to review Waiting for reviews label Jul 5, 2024
@solracsf solracsf added this to the Nextcloud 30 milestone Jul 5, 2024
@solracsf
Copy link
Member Author

solracsf commented Jul 5, 2024

/backport to stable29

@solracsf
Copy link
Member Author

solracsf commented Jul 5, 2024

/backport to stable28

@solracsf solracsf mentioned this pull request Jul 5, 2024
8 tasks
@solracsf solracsf force-pushed the s3InsertTimeout branch 4 times, most recently from b284748 to 1ce2838 Compare July 5, 2024 10:00
@solracsf solracsf requested a review from juliusknorr July 5, 2024 14:10
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: lint

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: use AwsException

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Throw on connection failure

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Wrap all in try catch block

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: use RequestTimeout error message

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

log: use OCP Server class

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Handle connect timeout only

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Handle errors more generically

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf
Copy link
Member Author

solracsf commented Jul 8, 2024

/backport to stable29

@solracsf
Copy link
Member Author

solracsf commented Jul 8, 2024

/backport to stable28

@solracsf solracsf added feature: object storage 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 8, 2024
@solracsf solracsf merged commit 6b523e8 into master Jul 9, 2024
165 checks passed
@solracsf solracsf deleted the s3InsertTimeout branch July 9, 2024 07:49
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: object storage feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: timeout not set in S3Client
3 participants