refactor: split app menu into smaller components #46370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
susnux
changed the title
artonge
approved these changes
Jul 9, 2024
|
/compile |
susnux
force-pushed
the
refactor/app-menu
branch
2 times, most recently
from
dcde62a to
a2bcc56
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
This allows to split one large block of code into three components with each one usecase. Allowing for better readability and maintainablility. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the app menu code is big chunk of code which is hard to maintain as you have to go through a lot of code first.
So I split it into smaller components for better maintainability.
This will also fix a problem where app icons are currently shown in their full size, e.g. if your app icon is 50x50px it will be shown as 50x50 pixels, as the previous 20px limitation was not working correctly.
There should be no visual changes except the previous icon size issue.
Checklist