feat: add base class for extending the query builder #46397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
artonge,
a team,
yemkareems,
sorbaugh and
come-nc
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
icewind1991
force-pushed
the
extended-query-builder-base
branch
2 times, most recently
from
acb6c83 to
8b5d787
Compare
icewind1991
force-pushed
the
extended-query-builder-base
branch
from
8b5d787 to
7a8a496
Compare
icewind1991
force-pushed
the
extended-query-builder-base
branch
4 times, most recently
from
c78506c to
803502e
Compare
come-nc
approved these changes
Jul 11, 2024
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
extended-query-builder-base
branch
from
803502e to
c82d382
Compare
artonge
approved these changes
Jul 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach of directly extending the
QueryBuildermeans that the database internals can't change the query builder used without breaking any "extended query builder".This introduces a new base class to build extended query builders of that encapsulates the regular query builder instead. Allowing the database internals to return different query builder implementations without breaking things.
Extracted from, and needed for the sharding work.