feat(files): Allow to configure Windows filename compatibility in the settings #46558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
2. developing
3 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| public function setFilesWindowsSupport(bool $enabled = true): void { | ||
| if ($enabled) { | ||
| $basenames = array_unique(array_values(array_merge(self::WINDOWS_BASENAMES, $this->filenameValidator->getForbiddenBasenames()))); |
Check failure
Code scanning / Psalm
RedundantFunctionCall Error
| public function setFilesWindowsSupport(bool $enabled = true): void { | ||
| if ($enabled) { | ||
| $basenames = array_unique(array_values(array_merge(self::WINDOWS_BASENAMES, $this->filenameValidator->getForbiddenBasenames()))); | ||
| $characters = array_unique(array_values(array_merge(self::WINDOWS_CHARACTERS, $this->filenameValidator->getForbiddenCharacters()))); |
Check failure
Code scanning / Psalm
RedundantFunctionCall Error
| if ($enabled) { | ||
| $basenames = array_unique(array_values(array_merge(self::WINDOWS_BASENAMES, $this->filenameValidator->getForbiddenBasenames()))); | ||
| $characters = array_unique(array_values(array_merge(self::WINDOWS_CHARACTERS, $this->filenameValidator->getForbiddenCharacters()))); | ||
| $extensions = array_unique(array_values(array_merge(self::WINDOWS_EXTENSION, $this->filenameValidator->getForbiddenExtensions()))); |
Check failure
Code scanning / Psalm
RedundantFunctionCall Error
susnux
force-pushed
the
feat/add-setting-for-windows-compat
branch
3 times, most recently
from
9a34e3c to
f0bba45
Compare
susnux
requested review from
skjnldsv,
Pytal,
ArtificialOwl,
come-nc,
artonge,
icewind1991,
szaimen and
nfebe
as code owners
susnux
added
3. to review
susnux
force-pushed
the
feat/add-setting-for-windows-compat
branch
from
f0bba45 to
b201a7e
Compare
Altahrim
approved these changes
Jul 17, 2024
susnux
force-pushed
the
feat/add-setting-for-windows-compat
branch
from
eeac0e1 to
74aac75
Compare
artonge
reviewed
Jul 17, 2024
apps/files/lib/Listener/DeclarativeSettingsGetValueEventListener.php
Outdated
Show resolved
Hide resolved
… settings This adds an admin setting to toggle Windows filename compatibility. Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Louis <louis@chmn.me> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/add-setting-for-windows-compat
branch
from
f5ca3d6 to
0936af9
Compare
artonge
approved these changes
Jul 17, 2024
Comment on lines
+33
to
+37
| $event->setValue( | ||
| match($event->getFieldId()) { | ||
| 'windows_support' => $this->service->hasFilesWindowsSupport(), | ||
| } | ||
| ); |
There was a problem hiding this comment.
Readability nitpick
Suggested change
| $event->setValue( | |
| match($event->getFieldId()) { | |
| 'windows_support' => $this->service->hasFilesWindowsSupport(), | |
| } | |
| ); | |
| if ($event->getFieldId() === 'windows_support') { | |
| $event->setValue($this->service->hasFilesWindowsSupport()); | |
| } |
Merged
|
Hi, |
|
@ThibautPlg currently not you would have to set every setting manually so manually configure invalid characters and extensions. But this is a planed feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds an admin setting to toggle Windows filename compatibility.
Checklist